Skip to content

feat(utils): add string helper#916

Merged
BioPhoton merged 12 commits intomainfrom
extend-utils
Feb 12, 2025
Merged

feat(utils): add string helper#916
BioPhoton merged 12 commits intomainfrom
extend-utils

Conversation

@BioPhoton
Copy link
Collaborator

@BioPhoton BioPhoton commented Jan 10, 2025

This PR includes helper for the TypeScript plugin #902

@BioPhoton BioPhoton marked this pull request as ready for review January 10, 2025 18:53
@BioPhoton BioPhoton requested a review from matejchalk January 10, 2025 18:53
@github-actions
Copy link
Contributor

github-actions bot commented Jan 10, 2025 •
edited
Loading

Code PushUp

🤨 Code PushUp report has both improvements and regressions – compared target commit d34b256 with source commit 6c7ed9f.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Categories

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Performance 🟡 55 🟡 51 ↓ −3.7
Documentation 🔴 23 🔴 23 ↑ +0.1
Code coverage 🟢 91 🟢 91 ↑ +0.1
Security 🟡 79 🟡 79 –
Updates 🟡 77 🟡 77 –
Accessibility 🟢 92 🟢 92 –
Best Practices 🟢 100 🟢 100 –
SEO 🟡 61 🟡 61 –
Bug prevention 🟢 100 🟢 100 –
Code style 🟢 100 🟢 100 –
👍 2 groups improved, 👎 1 group regressed, 👍 5 audits improved, 👎 6 audits regressed, 10 audits changed without impacting score

🗃️ Groups

🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
Lighthouse Performance 🟡 55 🟡 51 ↓ −3.7
JSDoc coverage Documentation coverage 🔴 23 🔴 23 ↑ +0.1
Code coverage Code coverage metrics 🟢 91 🟢 91 ↑ +0.1

15 other groups are unchanged.

🛡️ Audits

🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
Lighthouse Initial server response time was short 🟥 Root document took 610 ms 🟩 Root document took 450 ms ↓ −25.7 %
Lighthouse Speed Index 🟨 5.0 s 🟥 6.3 s ↑ +25.3 %
Lighthouse Time to Interactive 🟥 13.7 s 🟥 15.9 s ↑ +16.3 %
Lighthouse Largest Contentful Paint 🟨 3.3 s 🟨 3.5 s ↑ +4.6 %
Lighthouse First Contentful Paint 🟨 2.7 s 🟨 2.8 s ↑ +2.7 %
Lighthouse Total Blocking Time 🟥 3,800 ms 🟥 7,070 ms ↑ +86.2 %
JSDoc coverage Functions coverage 🟥 437 undocumented functions 🟥 437 undocumented functions +0 %
JSDoc coverage Types coverage 🟥 198 undocumented types 🟥 200 undocumented types ↑ +1 %
Code coverage Line coverage 🟩 90.1 % 🟩 90.1 % ↑ +0.1 %
Code coverage Branch coverage 🟨 86 % 🟨 86 % ↑ +0.1 %
Code coverage Function coverage 🟩 93.1 % 🟩 93.1 % ↑ +0.1 %
Lighthouse Minimizes main-thread work 🟥 13.3 s 🟥 20.0 s ↑ +50.3 %
Lighthouse JavaScript execution time 🟥 6.3 s 🟥 8.9 s ↑ +40.7 %
Lighthouse Metrics 🟩 100% 🟩 100% ↑ +16.3 %
Lighthouse Max Potential First Input Delay 🟥 1,800 ms 🟥 2,360 ms ↑ +31.3 %
Lighthouse Eliminate render-blocking resources 🟥 Potential savings of 840 ms 🟥 Potential savings of 510 ms ↓ −39.2 %
Lighthouse Reduce unused CSS 🟥 Potential savings of 67 KiB 🟥 Potential savings of 48 KiB ↓ −67.4 %
Lighthouse Server Backend Latencies 🟩 130 ms 🟩 300 ms ↑ +119.7 %
Lighthouse Avoids enormous network payloads 🟩 Total size was 1,816 KiB 🟩 Total size was 1,816 KiB ↑ +0.1 %
Lighthouse Network Round Trip Times 🟩 20 ms 🟩 60 ms ↑ +248 %
Lighthouse Uses efficient cache policy on static assets 🟨 27 resources found 🟨 27 resources found ↓ −0.1 %

574 other audits are unchanged.

@BioPhoton BioPhoton mentioned this pull request Jan 10, 2025
Closed
7 tasks
aramirezj
aramirezj previously requested changes Jan 10, 2025
View reviewed changes
matejchalk
matejchalk reviewed Jan 13, 2025
View reviewed changes
matejchalk
matejchalk approved these changes Jan 31, 2025
View reviewed changes
Copy link
Collaborator

@matejchalk matejchalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job with the refactor and the tests 👍

I think the type tests need some more setup (see comments), but I don't see it as a blocker for this PR.

@BioPhoton BioPhoton merged commit 6c0097f into main Feb 12, 2025
16 checks passed
@BioPhoton BioPhoton deleted the extend-utils branch February 12, 2025 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@matejchalk matejchalk matejchalk approved these changes

+1 more reviewer

@aramirezj aramirezj aramirezj left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@BioPhoton BioPhoton

Labels

🔬 testing writing tests 🧩 utils

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@BioPhoton @matejchalk @aramirezj